This is a follow-up question to my previous initialization variable question.
Suppose we're dealing with this context:
object AppProperties {
private var mgr: FileManager = _
def init(config: Config) = {
mgr = makeFileManager(config)
}
}
The problem with this code is that any other method in AppProperties might reassign mgr. Is there a technique to better encapsulate mgr so that it feels like a val for the other methods? I've thought about something like this (inspired by this answer):
object AppPropertie开发者_Go百科s {
private object mgr {
private var isSet = false
private var mgr: FileManager = _
def apply() = if (!isSet) throw new IllegalStateException else mgr
def apply(m: FileManager) {
if (isSet) throw new IllegalStateException
else { isSet = true; mgr = m }
}
}
def init(config: Config) = {
mgr(makeFileManager(config))
}
}
... but this feels rather heavyweight to me (and initialization reminds me too much of C++ :-)). Any other idea?
You could do it with implicits, making the implicit available only in the method that is supposed to be able to reassign. Viewing the value doesn't require the implicit, so the "variable" is visible to other methods:
sealed trait Access
trait Base {
object mgr {
private var i: Int = 0
def apply() = i
def :=(nv: Int)(implicit access: Access) = i = nv
}
val init = {
implicit val access = new Access {}
() => {
mgr := 5
}
}
}
object Main extends Base {
def main(args: Array[String]) {
println(mgr())
init()
println(mgr())
}
}
OK, so here's my proposal, directly inspired by axel22's, Rex Kerr's, and Debilski's answers:
class SetOnce[T] {
private[this] var value: Option[T] = None
def isSet = value.isDefined
def ensureSet { if (value.isEmpty) throwISE("uninitialized value") }
def apply() = { ensureSet; value.get }
def :=(finalValue: T)(implicit credential: SetOnceCredential) {
value = Some(finalValue)
}
def allowAssignment = {
if (value.isDefined) throwISE("final value already set")
else new SetOnceCredential
}
private def throwISE(msg: String) = throw new IllegalStateException(msg)
@implicitNotFound(msg = "This value cannot be assigned without the proper credential token.")
class SetOnceCredential private[SetOnce]
}
object SetOnce {
implicit def unwrap[A](wrapped: SetOnce[A]): A = wrapped()
}
We get compile-time safety that := is not called accidentally as we need the object's SetOnceCredential, which is returned only once. Still, the var can be reassigned, provided the caller has the original credential. This works with AnyVals and AnyRefs. The implicit conversion allows me to use the variable name directly in many circumstances, and if this doesn't work, I can explicitly convert it by appending ().
Typical usage would be as follows:
object AppProperties {
private val mgr = new SetOnce[FileManager]
private val mgr2 = new SetOnce[FileManager]
val init /*(config: Config)*/ = {
var inited = false
(config: Config) => {
if (inited)
throw new IllegalStateException("AppProperties already initialized")
implicit val mgrCredential = mgr.allowAssignment
mgr := makeFileManager(config)
mgr2 := makeFileManager(config) // does not compile
inited = true
}
}
def calledAfterInit {
mgr2 := makeFileManager(config) // does not compile
implicit val mgrCredential = mgr.allowAssignment // throws exception
mgr := makeFileManager(config) // never reached
}
This doesn't yield a compile-time error if at some other point in the same file, I try getting another credential and reassigning the variable (as in calledAfterInit), but fails at run-time.
I assume you don't need to do this efficiently with primitives, and for simplicity that you also don't need to store null (but you can of course modify the idea if these assumptions are false):
class SetOnce[A >: Null <: AnyRef] {
private[this] var _a = null: A
def set(a: A) { if (_a eq null) _a = a else throw new IllegalStateException }
def get = if (_a eq null) throw new IllegalStateException else _a
}
and just use this class wherever you need that functionality. (Maybe you would prefer apply() to get?)
If you really want it to look just like a variable (or method) access with no extra tricks, make the SetOnce private, and
private val unsetHolder = new SetOnce[String]
def unsetVar = unsetHolder.get
// Fill in unsetHolder somewhere private....
Not really the nicest way and not really what you asked for but it gives you some encapsulation of access:
object AppProperties {
def mgr = _init.mgr
def init(config: Config) = _init.apply(config)
private object _init {
var mgr: FileManager = _
def apply(config: Config) = {
mgr = makeFileMaker(config)
}
}
}
Looking at JPP’s post I have made another variation:
class SetOnce[T] {
private[this] var value: Option[T] = None
private[this] var key: Option[SetOnceCredential] = None
def isSet = value.isDefined
def ensureSet { if (value.isEmpty) throwISE("precondition violated: uninitialized value") }
def apply() = value getOrElse throwISE("uninitialized value")
def :=(finalValue: T)(implicit credential: SetOnceCredential = null): SetOnceCredential = {
if (key != Option(credential)) throwISE("Wrong credential")
else key = Some(new SetOnceCredential)
value = Some(finalValue)
key get
}
private def throwISE(msg: String) = throw new IllegalStateException(msg)
class SetOnceCredential private[SetOnce]
}
private val mgr1 = new SetOnce[FileManager]
private val mgr2 = new SetOnce[FileManager]
val init /*(config: Config)*/ = {
var inited = false
(config: Config) => {
if (inited)
throw new IllegalStateException("AppProperties already initialized")
implicit val credential1 = mgr1 := new FileManager(config)
mgr1 := new FileManager(config) // works
implicit val credential2 = mgr2 := new FileManager(config) // We get a new credential for this one
mgr2 := new FileManager(config) // works
inited = true
}
}
init(new Config)
mgr1 := new FileManager(new Config) // forbidden
This time, we are perfectly allowed to assign the var multiple times but we need to have the correct credential in scope. The credential is created and returned on first assign which is why we need to save it immediately to implicit val credential = mgr := new FileManager(config). If the credential is incorrect, it won’t work.
(Note that the implicit credential does not work if there are more credentials in scope because they’ll have the same type. It might be possible to work around this but I’m not sure at the moment.)
I was thinking something like:
object AppProperties {
var p : Int => Unit = { v : Int => p = { _ => throw new IllegalStateException } ; hiddenx = v }
def x_=(v : Int) = p(v)
def x = hiddenx
private var hiddenx = 0
}
X can be set exactly once.
It’s not exactly the same thing but in many cases, the solution for this ‘set the variable once and then keep using it’ is simple subclassing with or without a special factory method.
abstract class AppPropertyBase {
def mgr: FileManager
}
//.. somewhere else, early in the initialisation
// but of course the assigning scope is no different from the accessing scope
val AppProperties = new AppPropertyBase {
def mgr = makeFileMaker(...)
}
You can always move that value to another object, initialize it only once and access it when needed.
object FileManager {
private var fileManager : String = null
def makeManager(initialValue : String ) : String = {
if( fileManager == null ) {
fileManager = initialValue;
}
return fileManager
}
def manager() : String = fileManager
}
object AppProperties {
def init( config : String ) {
val y = FileManager.makeManager( config )
// do something with ...
}
def other() {
FileManager.makeManager( "x" )
FileManager.makeManager( "y" )
val y = FileManager.manager()
// use initilized y
print( y )
// the manager can't be modified
}
}
object Main {
def main( args : Array[String] ) {
AppProperties.init("Hello")
AppProperties.other
}
}
![Interactive visualization of a graph in python [closed]](https://www.devze.com/res/2023/04-10/09/92d32fe8c0d22fb96bd6f6e8b7d1f457.gif)
加载中,请稍侯......
精彩评论