PHP: make a function

function fullname($id){
$query = mysql_query("SELECT firstname, lastname FROM users WHERE id = '$id'");
$row = mysql_fetch_array($query);
$full_name = $row["firstname"] . " ".$row["lastname"];

return $full_name;
}

I want to grab firstname and lastname, put them together, and then echo it back开发者_运维百科, is this right?

---

if id field is an integer you do not have to use like 'id'

this is the correct line of code

$query = mysql_query("SELECT firstname, lastname FROM users WHERE id = $id");

---

why don't you join firstname and lastname in the sql?

$query = mysql_query("SELECT concat(firstname, ' ',lastname) as 'Name' FROM users WHERE id = $id");

normally this should also work

$query = mysql_query("SELECT firstname + ' ' + lastname as 'Name' FROM users WHERE id = $id");