I have two classes, Foo<T>
and Bar<T>
, derived from Base
. Each overrides a method virtual Base* convert(ID) const
, where ID
is an instance of a type that uniquely identifies a particular instantiation of Foo
or Bar
(pretend it's an enum
). The p开发者_如何转开发roblem is that Foo::convert()
needs to be able to return a Bar
instance, and likewise Bar::convert()
needs to be able to instantiate Foo
. Since they're both templates, this results in a circular dependency between Foo.h
and Bar.h
. How do I resolve this?
Edit: A forward declaration does not work because the implementation of each method needs the constructor of the other class:
Foo.h
:
#include <Base.h>
template<class T> class Bar;
template<class T>
class Foo : public Base { ... };
template<class T>
Base* Foo<T>::convert(ID id) const {
if (id == BAR_INT)
return new Bar<int>(value); // Error.
...
}
Bar.h
:
#include <Base.h>
template<class T> class Foo;
template<class T>
class Bar : public Base { ... };
template<class T>
Base* Bar<T>::convert(ID id) const {
if (id == FOO_FLOAT)
return new Foo<float>(value); // Error.
...
}
The error is, naturally, "invalid use of incomplete type".
What you need to do is seperate the class declarations from the implementation. So something like
template <class T> class Foo : public Base
{
public:
Base* convert(ID) const;
}
template <class T> class Bar : public Base
{
public:
Base* convert(ID) const;
}
template <class T> Base* Foo<T>::convert(ID) const {return new Bar<T>;}
template <class T> Base* Bar<T>::convert(ID) const {return new Foo<T>;}
This way, you have complete class definitions when the functions are defined.
(Updated) You should be able to handle that the same as with non-template classes. Write your Bar.h like this. (And similarly for Foo.h)
#if !defined(BAR_H_INCLUDED)
#define BAR_H_INCLUDED
template <class T>
class Foo;
template <class T>
class Bar
{
/// Declarations, no implementations.
}
#include "Foo.h"
template <class T>
Base* Bar<T>::Convert() { /* implementation here... */ }
#endif
You should use template class forward declarations in either headers
template <class T>
class X;
is perfectly good template class forward declaration.
James Curran's answer is a godsend. Generally speaking, James' idea is to restrict inclusion of required header files until the moment the members(' declarations) coming from included header files are needed. As an example:
t1.hh
#ifndef S_SIGNATURE
#define S_SIGNATURE
struct G; // forward declaration
template<typename T>
struct S {
void s_method(G &);
};
#include "t2.hh" // now we only need G's member declarations
template<typename T>
void S<T>::s_method(G&g) { g.g_method(*this); }
#endif
t2.hh
#ifndef G_SIGNATURE
#define G_SIGNATURE
template<typename T>
struct S; // forward declaration
struct G {
template<typename T>
void g_method(S<T>&);
};
#include "t1.hh" // now we only need S' member declarations
template<typename T>
void G::g_method(S<T>& s) { s.s_method(*this); }
#endif
t.cc
#include "t1.hh"
#include "t2.hh"
S<int> s;
G g;
int main(int argc,char**argv) {
g.g_method(s); // instantiation of G::g_method<int>(S<int>&)
}
精彩评论