Simple PHP statement, I can't get it to work!

How to get $schedule = true` and $schedule2 = true to work?

I know this is easy and I'm overlooking something simple!

Here is the full code:

I basically want schedule and schedule2 to work (it looks at a PHP date and tells it when to expire on our news site!)

$where = array();
$where = run_filters('also-allow', $where);

if ($allow_full_story or $allow_add_comment) {
    $post = 'full';

    if ($title){
        $where[] = "url = $title";
    } elseif ($time){
        $where[] = "date = $time";
    } elseif ($id){
        $where[] = "id = $id";
    }
} else {
    $post = 'short';

    if (!$is_logged_in or $is_logged_in and $member['level'] == 4) {
        $where[] = 'hidden = 0';
        $where[] = 'and';
    }

  开发者_运维问答  if ($user or $author) {
        $where[] = 'author = '.($author ? $author : $user);
        $where[] = 'and';
    }

    if ($year and !$month) {
        $where[] = 'date > '.@mktime(0, 0, 0, 1, 1, $year);
        $where[] = 'and';
        $where[] = 'date < '.@mktime(23, 59, 59, ($year == date("Y") ? date("n") : 12), ($year == date("Y") ? date("d") : 31), $year);
    } elseif ($year and $month and !$day) {
        $where[] = 'date > '.@mktime(0, 0, 0, $month, 1, $year);
        $where[] = 'and';
        $where[] = 'date < '.@mktime(23, 59, 59, $month, (($year == date("Y") and $month >= date("n")) ? date("d") : 31), $year);
    } elseif ($year and $month and $day) {
        if($year == date("Y") and $month >= date("n") and $day >= date("d")) {
            $where[] = 'hidden = 2';
        }
        else {
            $where[] = 'date > '.@mktime(0, 0, 0, $month, $day, $year);
            $where[] = 'and';
            $where[] = 'date < '.@mktime(23, 59, 59, $month, $day, $year);
        }
    }
    else {
    if ($schedule) {
        $where[] = 'date > '.(time() + $config_date_adjust * 60 - 432000);
    }
    else {
        $where[] = 'date < '.(time() + $config_date_adjust * 60);
    }
    $schedule = false;
}
else {
    if ($schedule2) {
        $where[] = 'date > '.(time() + $config_date_adjust * 60 - 86400);
    }
    else {
        $where[] = 'date < '.(time() + $config_date_adjust * 60);
    }
    $schedule2 = false;
}

---

You can't have 2 elses in a row. Maybe elseif, but no one know your logic.

---

Clean Code: A Handbook of Agile Software Craftsmanship (Paperback)

---

You use too many else's. Try to simplify your code, use CASE.