CGImage/UIImage passing causes EXE-BAD-ACCESS

FIXED: I'开发者_StackOverflow中文版m not sure yet why. Code has been updated below, and notes at the bottom

I'm having a very strange error that does not show up on the Simulator (even when running Instruments), unless I turn on all the Zombie and Debug options. However, it will crash the phone after a minute of updates (1 update per second). I have a 2D array that I take a subset of, apply a colormap, and turn into an image (this array changes constantly). Then I pass that image to the model, and the viewcontroller grabs it from the model once it receives notification of an update. I'll layout the 3 classes -Spectrogram, Model, ViewController:

Here are the important bits of each (there is more, but not relevant):

Spectrogram.h (Sorry, I can't get this to indent correctly on here)

@interface: Spectrogram : NSObject
{
    NSMutableData *arrayData;
}
//renamed so Xcode allows the object with +1 reference count to be returned
- (CGImageRef)newSpectrogramImage;  

Spectrogram.m

@implementation Spectrogram
- (CGImageRef)newSpectrogramImage
{
    //slightly reordered
    NSMutableData *imageData = [[NSMutableData alloc] init];
    ...code to go through arrayData and colormap it (get RGB transform) and store in imageData...
    CGImageRef arrayImage = nil;
    CGColorSpaceRef colorSpace = CGColorSpaceCreateDeviceRGB();
    //specifically tell CGImage there is no alpha channel
    CGBitmapInfo bitmapInfo = kCGBitmapByteOrderDefault | kCGImageAlphaNone;
    //Use the toll-free bridge between NSData and CFData
    CGDataProviderRef provider = CGDataProviderCreateWithCFData((CFDataRef)imageData);
    arrayImage = CGImageCreate((slices-startSlice), bins, 8, 24, 3*(slices-startSlice), colorSpace, bitmapInfo, provider, NULL, false, kCGRenderingIntentDefault);  //image is rotated now, so width and height are switched
    CGColorSpaceRelease(colorSpace);
    CGDataProviderRelease(provider);
    CGImageRelease(arrayImage);
    [imageData release];
    //Pass the CGImageRef with a reference count of 1
    return arrayImage;
}

Model.h

@interface: Model : NSManagedObject
{
    Spectrogram *spectrogram;
}
//Function the viewController can call to get the update
- (CGImageRef)newSpectrogramImage;  

Model.m

@implementation Model
... there is a function that adds new data to the array and notifies all listeners...
- (CGImageRef)newSpectrogramImage {
    return [spectrogram newSpectrogramImage];
}

ViewController.h

@interface: ViewController : UIViewController 
{ 
}
//the root controller actually alloc's the record, and sets this property when creating this view
@property (nonatomic, retain) Record *currentRecord;  

ViewController.m

@implementation ViewController
@synthesize spectrogramView;
- (void)viewDidLoad
{
    [super viewDidLoad];
    [[NSNotificationCenter ... listen for model updates...
}

//now, the real meat
- (void)recordUpdated:(NSNotification*)notification
{
    CALayer *myLayer = self.view.layer;
    CGImageRef spectrogramImage = nil;
    spectrogramImage = [currentRecord newSpectrogramImage];
    myLayer.contents = (id)spectrogramImage;
    CGImageRelease(spectrogramImage); 
}

I've changed this so many times in the last day trying to hunt down where and why it fails. I've tried passing the CGImageRef instead (but since that isn't an object, I'm worried about making copies of what can be a -huge- image) and it still fails. And it works perfectly in the simulator (will run for dozens of minutes). But fails within a minute on the iphone, or if I turn on the debug options for the simulator (it will fail as soon as the viewcontroller is loaded).

On a side note, that might be of some use. This viewcontroller is loaded as a modal view when the phone is turned sideways (works great). However, I have a lot of NSLogs in there and I see this viewcontroller's dealloc is called before the mainviewcontroller even gets to viewwilldisappear - but it still runs. And then this controller's dealloc is called again when the phone is turned back and the view disappears.

Note The version that worked well in the simulator passed CGImageRefs all the way to the viewController, instead of UIImages. I've tried at least 50 different combinations of where to create the UIImage from the CGImage, and what's posted above is just one of them (all of them fail eventually, or immediately). Of note, with the code above, if I do add this to the viewController modelUpdated:

CGSize size = currentModel.spectrogramImage.size;
NSLog(@"width: %f", size.width);

and comment out assigning it to the spectrogramView, the width is reported correctly, so the UIImage is getting passed along, it's just not getting retained (This is how I understand the EXE_BAD_ACCESS error).

Also, recently I receive dan EXE_BAD_ACCESS on the

self.spectrogramImage = [spectrogram getSpectrogramImage];

line. So, I think the error may be inside the Spectrogram class. Even though the CGImage and UIImage code was taken from Apple examples.

Fixed notes I read that setting the contents of the CALayer was a much quicker way to pass a CGImageRef to a view - and no UIImage intermediary. Unfortunately, I only commit working changes, so I can't see every iteration I went through. However, I know that I had something very similar to this several times that kept crashing. The problem was always that as it is currently written, the program would crash with EXE_BAD_ACCESS. And if I upped the reference count (or didn't release it), then it would work perfectly, but the object would leak. I still don't understand how that is possible. To have the difference between a leak, and a BAD ACCESS be a reference count of 1 (and not 2 or more).

---

I can't answer your specific question, but this might help you know what is going on a little bit better. I have a function "logMemUsage" that outputs your memory usage and shows how much it changed since last time. If you call it once a second or so, you can better understand how memory is being used in your app. If it keeps growing, obviously there's a leak, if it goes up and down as you expect it, that's good, if it doesn't go down when you think it should, you'll see it. It's in github here in Utilities.h/.m

---

It's hard to figure this out from what you've posted, but why not use properties with retain on all your allocated data? For example, you're returning an autoreleased UIImage from getSpectrogramImage, and it gets stored into Model with the call self.spectrogramImage = [spectrogram getSpectrogramImage];, but there isn't a property for spectrogramImage anywhere I can see, even though you're using the self. mechanism. Is it just that you didn't bother to post it? The way it's written it could be getting autoreleased, and then when you try to use it...