开发者

How can I make this code simpler?

开发者 https://www.devze.com 2023-03-08 01:29 出处:网络
if(condition 1){ var=changeVar(var); chang开发者_开发问答ed=true; } if(condition 2){ var=changeVar2(var);
if(condition 1){
 var=changeVar(var);
 chang开发者_开发问答ed=true;
}

if(condition 2){
 var=changeVar2(var);
 changed=true;
}

if(condition 3){
 var=changeVar3(var);
 changed=true;
}

I don't like how changed=true; is repeated three times.


You could save the old var, and compare it?

oldVar = var;

//your code here.

changed = (oldVar != var);

I had == in there at first, but wouldn't that give a wrong (or at least different) sollution then in the question?


<?php
if (condition 1) {
    var=changeVar(var);
}
if (condition 2) {
    var=changeVar2(var);
}
if (condition 3) {
    var=changeVar3(var);
}
changed=(condition 1||condition 2||condition 3||changed); // set changed value only if condition 1, condition 2 or condition 3 is true, keep old value otherwise
?>


if (condition 1 || condition 2 || condition 3) {
    if (condition 1) {
        var = changeVar(var);
    }
    if (condition 2) {
        var = changeVar2(var);
    }
    if (condition 3) {
        var = changeVar3(var);
    }
    changed = true;
}


$changed = true;
if ($cond1) {}
elseif ($cond2) {}
else { $changed = false; }


if(condition1||condition2||condition3) {
    switch(condition) {
        case 1: var = changeVar(var);
        break;
        case 2: var = changeVar2(var);
        break;
        case 3: var = changeVar3(var);
        break;
    }
    changed = true;
}
0

精彩评论

暂无评论...
验证码 换一张
取 消